"Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote
>>> True, but current code just check the return value of AllocateABC() then
>>> decide to upgrade elevel to FATAL.
> In ValidatePgVersion(), FindMyDatabase(), etc -- though in practice this
> error can hardly happen anyway.
Doesn't matter because those functions only run during backend startup,
a time when ERROR and FATAL are equivalent anyhow. It's debatable
whether those functions should be coded with the error level as ERROR
or FATAL --- there's no functional difference but it seems marginally
clearer to me to write FATAL in places where we know an error is going
to force backend exit. You might see it differently though.
regards, tom lane
In response to
pgsql-patches by date
|Next:||From: Simon Riggs||Date: 2006-06-13 08:27:05|
|Subject: Re: [PATCHES] Non-transactional pg_class, try 2|
|Previous:||From: Qingqing Zhou||Date: 2006-06-13 01:58:24|
|Subject: Re: minor fix of elevel in fd.c|