Skip site navigation (1) Skip section navigation (2)

Re: minor fix of elevel in fd.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: minor fix of elevel in fd.c
Date: 2006-06-13 02:09:02
Message-ID: 14986.1150164542@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
"Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote
>>> True, but current code just check the return value of AllocateABC() then
>>> decide to upgrade elevel to FATAL.
>> 
>> Where?

> In ValidatePgVersion(), FindMyDatabase(), etc -- though in practice this
> error can hardly happen anyway.

Doesn't matter because those functions only run during backend startup,
a time when ERROR and FATAL are equivalent anyhow.  It's debatable
whether those functions should be coded with the error level as ERROR
or FATAL --- there's no functional difference but it seems marginally
clearer to me to write FATAL in places where we know an error is going
to force backend exit.  You might see it differently though.

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Simon RiggsDate: 2006-06-13 08:27:05
Subject: Re: [PATCHES] Non-transactional pg_class, try 2
Previous:From: Qingqing ZhouDate: 2006-06-13 01:58:24
Subject: Re: minor fix of elevel in fd.c

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group