Re: [HACKERS] WITH RECURSIVE patch V0.1

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: "Yoshiyuki Asaba" <y-asaba(at)sraoss(dot)co(dot)jp>, david(at)fetter(dot)org, zb(at)cybertec(dot)at, ishii(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] WITH RECURSIVE patch V0.1
Date: 2008-05-25 18:33:34
Message-ID: 14960.1211740414@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

[ catching up on back email ]

Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> "Yoshiyuki Asaba" <y-asaba(at)sraoss(dot)co(dot)jp> writes:
>> Recursive query does not consume stack. The server enters an infinite
>> loop without consuming stack. Stack-depth error does not happen.

> We could have a separate guc variable which limits the maximum number of
> levels of recursive iterations. That might be a useful feature for DBAs that
> want to limit their users from issuing an infinite query.

This whole thread seems to be proposing more and more complicated
solutions for what is really a non-problem given Yoshiyuki-san's point.
It's trivial to construct SQL queries that will run for longer than the
MTBF of your hardware --- eg, forget a few join constraints. We've
gotten along fine with nothing but query cancel and statement_timeout
for that, and I've seen no one proposing that we need to "fix it".
We don't disallow you from writing an infinite loop in plpgsql, either.

I think this patch is plenty complicated enough without adding useless
restrictive options.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-05-25 18:41:39 Re: pg_dump roles support
Previous Message Joshua D. Drake 2008-05-25 18:30:50 Re: [HACKERS] WITH RECURSIVE patch V0.1

Browse pgsql-patches by date

  From Date Subject
Next Message David Fetter 2008-05-25 20:56:31 Re: Updated patch (Re: WITH RECURSIVE patch V0.1)
Previous Message Joshua D. Drake 2008-05-25 18:30:50 Re: [HACKERS] WITH RECURSIVE patch V0.1