Re: [HACKERS] psql \copy warning

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Jeremy Drake <pgsql(at)jdrake(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] psql \copy warning
Date: 2006-05-28 05:00:18
Message-ID: 14197.1148792418@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> The attached patch fixes the warning you received by adding E'' strings
> to the \copy arguments, and adds it for the other backslash commands
> like \d.

You missed the point entirely Bruce. The problem is that \copy's
argument parsing won't accept an option specified as E'\t' --- I believe
it is seeing that as two arguments instead of one.

The patch you propose addresses a completely different issue, which is
whether we are going to E-ify all our utilities so they don't trigger
the escape_string_warning patch. I don't think that that is the right
direction to go in. In fact, based on what I was doing this afternoon,
my feeling is that 8.2 will not ship with escape_string_warning turned
on by default. It's a good tool for testing code when you're trying to
move the code over to standard conforming strings, but it's just too
noisy for code that in point of fact is already fixed.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rémi Zara 2006-05-28 09:00:17 Re: osprey buildfarm member has been failing for a long while
Previous Message Chris Broussard 2006-05-28 04:13:58 Schema Limitations ?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-05-28 22:22:45 Re: [HACKERS] psql \copy warning
Previous Message Bruce Momjian 2006-05-28 03:25:23 Re: [HACKERS] psql \copy warning