Skip site navigation (1) Skip section navigation (2)

Re: CVS tip problems

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: olly(at)lfix(dot)co(dot)uk, pgsql-hackers(at)postgresql(dot)org
Subject: Re: CVS tip problems
Date: 2004-06-01 02:10:04
Message-ID: 14191.1086055804@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> The code we have appears to assume that the result will always be placed
>> in the user-supplied buffer, which is apparently NOT what the glibc
>> version does.

> What does "may, but need not, use the user-supplied buffer" supposed to
> mean in practical terms.  How do they expect us to use it?

AFAICS they expect you to use the function's return value.

The current PG code is really erroneous for *both* strerror_r specs,
since the SUS-spec version doesn't promise to put anything into the
buffer if it returns a failure code.  I think you will have to write
some autoconf code to detect which return type is provided, and do
the right things with the return value in both cases.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Claudio NatoliDate: 2004-06-01 02:13:21
Subject: Re: Can't detect time zone
Previous:From: Neil ConwayDate: 2004-06-01 02:04:23
Subject: Re: Converting postgresql.conf parameters to kilobytes

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-06-01 03:31:42
Subject: Re: Fully enabling NLS in pg_ctl
Previous:From: Bruce MomjianDate: 2004-06-01 02:01:34
Subject: Re: CVS tip problems

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group