Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Fix float8 parsing of denormal values (on some platforms?)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jeroen Vermeulen <jtv(at)xs4all(dot)nl>
Subject: Re: [PATCH] Fix float8 parsing of denormal values (on some platforms?)
Date: 2012-02-03 08:49:38
Message-ID: 14168.1328258978@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Marti Raudsepp <marti(at)juffo(dot)org> writes:
> We're already seeing first buildfarm failures, on system "narwhal"
> using an msys/mingw compiler.

Yeah.  After a full day's cycle, the answer seems to be that
denormalized input works fine everywhere except:

1. mingw on Windows (even though MSVC builds work)

2. some Gentoo builds fail (knowing that platform, the phase of the moon
is probably the most predictable factor determining this).

I'm inclined at this point to remove the regression test cases, because
we have no principled way to deal with case #2.  We could install
alternative "expected" files that accept the failure, but then what's
the point of having the test case at all?

It might be worth pressuring the mingw folk to get with the program,
but I'm not going to be the one to do that.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2012-02-03 09:06:01
Subject: Re: [PATCH] Fix float8 parsing of denormal values (on some platforms?)
Previous:From: Tom LaneDate: 2012-02-03 07:47:15
Subject: Re: BUG #6425: Bus error in slot_deform_tuple

Privacy Policy | About PostgreSQL
Copyright © 1996-2013 The PostgreSQL Global Development Group