Re: like/ilike improvements

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: like/ilike improvements
Date: 2007-05-22 16:12:51
Message-ID: 14164.1179850371@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> ... It turns out (according to the analysis) that the
> only time we actually need to use NextChar is when we are matching an
> "_" in a like/ilike pattern.

I thought we'd determined that advancing bytewise for "%" was also risky,
in two cases:

1. Multibyte character set that is not UTF8 (more specifically, does not
have a guarantee that first bytes and not-first bytes are distinct)

2. "_" immediately follows the "%".

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2007-05-22 16:30:37 Re: like/ilike improvements
Previous Message Andrew Dunstan 2007-05-22 15:58:33 like/ilike improvements

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2007-05-22 16:30:37 Re: like/ilike improvements
Previous Message Andrew Dunstan 2007-05-22 15:58:33 like/ilike improvements