"Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> writes:
> Seems you have changed the position of ResetAllOptions() as follows.
> + /*
> + * Options setup
> + */
> if (getenv("PGDATA"))
> DataDir = strdup(getenv("PGDATA")); /* default value */
> if (getenv("PGPORT"))
> PostPortName = atoi(getenv("PGPORT"));
> + ResetAllOptions();
Hmm, actually I was trying to move it to after the memory-context
creation code, but I guess your point is that ResetAllOptions() is
ignoring these env-var-based settings. Seems like the correct fix
is that guc.c ought to be handling this logic, not postmaster.c.
Peter, what do you think?
regards, tom lane
In response to
Responses
pgsql-hackers by date
| Next: | From: Oleg Broytmann | Date: 2000-07-03 07:43:47 |
| Subject: Re: Built with PostgreSQL (images) |
| Previous: | From: Hiroshi Inoue | Date: 2000-07-03 04:26:59 |
| Subject: RE: pgsql/src/backend/postmaster (postmaster.c) |
pgsql-committers by date
| Next: | From: Hiroshi Inoue | Date: 2000-07-03 04:45:10 |
| Subject: pgsql/src/backend/utils/time (tqual.c) |
| Previous: | From: Hiroshi Inoue | Date: 2000-07-03 04:26:59 |
| Subject: RE: pgsql/src/backend/postmaster (postmaster.c) |