Re: [HACKERS] bgwriter_lru_multiplier blurbs inconsistent

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Smith <gsmith(at)gregsmith(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-docs(at)postgresql(dot)org, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] bgwriter_lru_multiplier blurbs inconsistent
Date: 2008-01-20 22:05:22
Message-ID: 13942.1200866722@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

Greg Smith <gsmith(at)gregsmith(dot)com> writes:
> There is nothing incorrect here, it's just not as clear as it could be.
> Here's a V2 that tries to clear that up:

> Unless limited by <varname>bgwriter_lru_maxpages</>, the number of dirty
> buffers written in each round is based on the number of new buffers that
> have been needed by server processes during recent rounds. The recent
> need is multiplied by <varname>bgwriter_lru_multiplier</> to arrive at the
> estimate of the number of buffers that will be needed during the next
> round. Buffers are written to meet that need if there aren't enough
> reusable ones found while scanning.

I think the main problem is the qualifying clause up front in a place
of prominence. Here's a V3 try:

The number of dirty buffers written in each round is based on the number
of new buffers that have been needed by server processes during recent
rounds. The average recent need is multiplied by
<varname>bgwriter_lru_multiplier</> to arrive at the estimate of the
number of buffers that will be needed during the next round. Dirty
buffers are written until there are that many clean, reusable buffers
available. However, no more than <varname>bgwriter_lru_maxpages</>
buffers will be written per round.

regards, tom lane

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Greg Smith 2008-01-21 03:07:52 Re: [HACKERS] bgwriter_lru_multiplier blurbs inconsistent
Previous Message Greg Smith 2008-01-20 20:55:54 Re: [HACKERS] bgwriter_lru_multiplier blurbs inconsistent

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-01-20 22:07:29 Re: Minor bug in src/port/rint.c
Previous Message Magnus Hagander 2008-01-20 22:00:33 Re: Minor bug in src/port/rint.c