Skip site navigation (1) Skip section navigation (2)

Re: Macros for typtype (was Re: Arrays of Complex Types)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, David Fetter <david(at)fetter(dot)org>
Subject: Re: Macros for typtype (was Re: Arrays of Complex Types)
Date: 2007-04-01 02:31:26
Message-ID: 13829.1175394686@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>> I just realized that I need to check every usage of typtype to be
>>> sure that the enums patch is sane.  So, barring objection, I intend
>>> to take this opportunity to make the code stop referring directly
>>> to 'b', 'c' etc whereever possible.  Any objections to these names?

> Why not enums? ;-)

Well, macros is how we do it elsewhere for "char" system columns.
I'm not sure we could rely on the behavior if we declared
pg_type.typtype as an enum type ... and if we don't, there's not
much point.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Mark DilgerDate: 2007-04-01 02:47:21
Subject: Re: Bug in UTF8-Validation Code?
Previous:From: Greg SmithDate: 2007-04-01 01:30:34
Subject: pgbench transaction timestamps

pgsql-patches by date

Next:From: Russell SmithDate: 2007-04-01 02:33:43
Subject: Re: Add usage counts to pg_buffercache
Previous:From: Greg SmithDate: 2007-04-01 02:20:55
Subject: Add usage counts to pg_buffercache

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group