Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL
Date: 2007-10-02 14:04:19
Message-ID: 13826.1191333859@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> I thought of a compromise. We can put back a check if the file exists without using bio. That would cover some 99 percent of the messages coming out of that 
>> routine, I bet. And things would still work correct in 0.9.8.

> Here's an example of what I meant.

+1, but I think you should "#ifndef HAVE_ERR_SET_MARK" the added code.
Also, maybe try to fopen rather than just fstat?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Michael MeskesDate: 2007-10-02 14:11:20
Subject: Re: pgsql: ITAGAKI Takahiro<itagaki.takahiro@oss.ntt.co.jp> added
Previous:From: Michael MeskesDate: 2007-10-02 13:42:45
Subject: Re: pgsql: ITAGAKI Takahiro<itagaki.takahiro@oss.ntt.co.jp> added

pgsql-committers by date

Next:From: Michael MeskesDate: 2007-10-02 14:11:20
Subject: Re: pgsql: ITAGAKI Takahiro<itagaki.takahiro@oss.ntt.co.jp> added
Previous:From: Michael MeskesDate: 2007-10-02 14:01:57
Subject: pgsql: Made new test also work without threading enabled.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group