| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Zoltan Boszormenyi <zb(at)cybertec(dot)at>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: float4/float8/int64 passed by value with tsearch fixup |
| Date: | 2008-04-18 19:41:28 |
| Message-ID: | 13788.1208547688@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tom Lane wrote:
>> Since they're v0, they'd have to explicitly know about the pass-by-ref
>> status of float4.
> Well, the previous code was doing some pallocs, and the new code is not:
> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/seg/seg.c.diff?r1=1.20;r2=1.21
[ shrug... ] So, you missed something.
>> Did this patch include a compile-time choice of whether things could
>> remain pass-by-ref? I rather imagine that some people out there will
>> prefer to stay that way instead of fix their old v0 code.
> Hmm, nope. Do we really need that?
Given that we *have to* handle a compile-time choice for whether float8
is pass-by-ref, I should think that allowing a similar choice for float4
is perfectly sensible and not really more work (it'll just be a second
instance of the same code pattern).
I'm not at all sure it made sense to apply this portion of the patch
separately.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-04-18 20:09:26 | Re: float4/float8/int64 passed by value with tsearch fixup |
| Previous Message | Alvaro Herrera | 2008-04-18 19:23:04 | Re: float4/float8/int64 passed by value with tsearch fixup |