Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY
Date: 2008-01-15 21:45:44
Message-ID: 13779.1200433544@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> That's what the docs say, but Tom's patch also adds lines to handle
> NOTIFY, which is what prompted the question.

I don't believe that code can get executed given the current backend
design.  I just put it in because the protocol spec says (and always
has said)

Note: At present, NotificationResponse can only be sent outside a
transaction, and thus it will not occur in the middle of a
command-response series, though it might occur just before
ReadyForQuery. It is unwise to design frontend logic that assumes that,
however. Good practice is to be able to accept NotificationResponse at
any point in the protocol.


			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-01-15 21:48:02
Subject: Re: [COMMITTERS] pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY
Previous:From: Tom LaneDate: 2008-01-15 21:41:42
Subject: Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY

pgsql-committers by date

Next:From: Tom LaneDate: 2008-01-15 21:48:02
Subject: Re: [COMMITTERS] pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY
Previous:From: Tom LaneDate: 2008-01-15 21:41:42
Subject: Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group