Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: "PostgreSQL-development Hackers" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch
Date: 2007-09-26 23:33:03
Message-ID: 13737.1190849583@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> [ revised version of tuptoaster-fixup.patch ]

I've applied most of this.  I didn't like the hardwired assumption about
minimum size to compress, and anyway you had put it in a place where it
broke the intended behavior for SET STORAGE PLAIN.  I replaced it with
just a test to save palloc/pfree overhead in toast_compress_datum, which
has at least got knowledge of which PGLZ strategy is being used.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Florian G. PflugDate: 2007-09-27 00:29:17
Subject: Re: [FEATURE REQUEST] Streaming Onlinebackup (Maybe OFFTOPIC)
Previous:From: Kevin GrittnerDate: 2007-09-26 23:09:55
Subject: Re: [FEATURE REQUEST] Streaming Onlinebackup (MaybeOFFTOPIC)

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-09-27 05:23:07
Subject: Re: Minor changes to Recovery related code
Previous:From: Tom LaneDate: 2007-09-26 22:38:24
Subject: Re: Minor recovery changes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group