Skip site navigation (1) Skip section navigation (2)

Re: v7.4.1 text_position() patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Korea PostgreSQL Users' Group" <pgsql-kr(at)postgresql(dot)or(dot)kr>
Cc: pgsql-patches(at)postgresql(dot)org, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
Subject: Re: v7.4.1 text_position() patch
Date: 2004-01-30 15:31:52
Message-ID: 13708.1075476712@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
"Korea PostgreSQL Users' Group" <pgsql-kr(at)postgresql(dot)or(dot)kr> writes:
> In src/backend/utils/adt/varlena.c,
> 766 line must be exits in block of 'else if (elm >1)' too.
> Because, strpos() function make a wrong result in multibyte string. 

Hm.  I don't think it can actually fail, because the wchar strings are
zero-terminated.  But it does look like there's a missed speedup here.
(Tatsuo, do you agree?)

Thanks for the report!

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2004-01-30 15:39:46
Subject: Re: Question about indexes
Previous:From: Bruce MomjianDate: 2004-01-30 15:30:42
Subject: Re: Question about indexes

pgsql-patches by date

Next:From: Korea PostgreSQL Users' GroupDate: 2004-01-30 16:25:32
Subject: Re: v7.4.1 text_position() patch
Previous:From: Korea PostgreSQL Users' GroupDate: 2004-01-30 14:32:37
Subject: v7.4.1 text_position() patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group