Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Text <-> C string

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Brendan Jurd" <direvus(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] Text <-> C string
Date: 2008-03-28 19:26:21
Message-ID: 13684.1206732381@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
"Brendan Jurd" <direvus(at)gmail(dot)com> writes:
> On 26/03/2008, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> There are no textout/textin calls left, but I may have missed some
>> places that were doing it the hard way with direct palloc/memcpy
>> manipulations.  It might be worth trolling all the VARDATA() references
>> to see if any more are easily replaceable.

> I think there are perhaps a dozen such sites, and I hope to submit a
> cleanup patch that gets rid of these soon.
> I did come across one site I'm not sure about in utils/adt/xml.c:291

I intentionally didn't touch xml.c, nor anyplace that is not dealing
in text, even if it happens to be binary-compatible with text.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Brendan JurdDate: 2008-03-28 19:40:46
Subject: Re: [PATCHES] Text <-> C string
Previous:From: Simon RiggsDate: 2008-03-28 19:09:59
Subject: Re: [PATCHES] Implemented current_query

pgsql-patches by date

Next:From: Brendan JurdDate: 2008-03-28 19:40:46
Subject: Re: [PATCHES] Text <-> C string
Previous:From: Simon RiggsDate: 2008-03-28 19:09:59
Subject: Re: [PATCHES] Implemented current_query

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group