Re: Bytea as C string in pg_convert?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Bytea as C string in pg_convert?
Date: 2007-09-24 14:32:19
Message-ID: 13668.1190644339@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> We can and possibly should change the GETARG call, but the varlena types
> are structurally equivalent, so it's not a mortal sin being committed here.

We *definitely* should change it --- the reason for having all those
variant macros in the first place was to help document the argument
types of V1 functions. It's too bad the compiler doesn't warn about
the type mismatch here ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2007-09-24 15:07:17 Re: Bytea as C string in pg_convert?
Previous Message Gregory Stark 2007-09-24 14:15:01 Re: [PATCHES] Eliminate more detoast copies for packed varlenas