Re: plpgsql, return can contains any expression

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, "Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, neilc(at)samurai(dot)com
Subject: Re: plpgsql, return can contains any expression
Date: 2006-09-04 22:11:16
Message-ID: 13599.1157407876@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com> writes:
> This patch allows using any row expression in return statement and does
> transformation from untyped row to composite types if it's necessary.

This patch doesn't seem to cope with cases where the supplied tuple has
the wrong number of columns, and it doesn't look like it's being careful
about dropped columns either. Also, that's a mighty bizarre-looking
choice of cache memory context in coerce_to_tuple ... but then again,
why are you bothering with a cache at all for temporary arrays?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2006-09-04 22:11:53 Re: [PATCHES] Trivial patch to double vacuum speed on tables with no indexes
Previous Message Greg Sabino Mullane 2006-09-04 22:04:24 Re: Information schema - finalize key_column_usage

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2006-09-04 22:11:53 Re: [PATCHES] Trivial patch to double vacuum speed on tables with no indexes
Previous Message Greg Sabino Mullane 2006-09-04 22:04:24 Re: Information schema - finalize key_column_usage