Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Instead of trying (and failing) to allow <<label>> at the end of

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Instead of trying (and failing) to allow <<label>> at the end of
Date: 2010-03-03 06:00:26
Message-ID: 13586.1267596026@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
David Fetter <david(at)fetter(dot)org> writes:
> On Tue, Mar 02, 2010 at 11:02:54PM -0500, Jaime Casanova wrote:
>> On Tue, Mar 2, 2010 at 8:53 PM, Tom Lane <tgl(at)postgresql(dot)org> wrote:
>>> Instead of trying (and failing) to allow <<label>> at the end of a DECLARE
>>> section, throw an error message saying explicitly that the label must go
>>> before DECLARE.
>> 
>> with the docs saying another thing, this couldn't be considered as a
>> bug fix and therefore backpatchable

> +1 for back-patching.

No, I intentionally didn't back-patch that.  The only benefit of the
change is throwing a useful error message for questionable syntax.
As against that we have the possibility of breaking code that works
now, if someone's got an incorrectly-placed label that they're not
actually referencing.  I grant that that's not a very likely case;
but the error that the message would help people fix isn't very
likely either, as demonstrated by the fact that this never came up
before.  We shouldn't be making changes in the behavior of back
branches for such things.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: KaiGai KoheiDate: 2010-03-03 06:03:00
Subject: Re: renameatt() can rename attribute of index, sequence, ...
Previous:From: A. KretschmerDate: 2010-03-03 05:55:43
Subject: Re: [GENERAL] to_timestamp() and quarters

pgsql-committers by date

Next:From: Jaime CasanovaDate: 2010-03-03 06:07:11
Subject: Re: Re: [COMMITTERS] pgsql: Instead of trying (and failing) to allow <<label>> at the end of
Previous:From: David FetterDate: 2010-03-03 04:59:49
Subject: Re: [COMMITTERS] pgsql: Instead of trying (and failing) to allow <<label>> at the end of

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group