Skip site navigation (1) Skip section navigation (2)

Can't ri_KeysEqual() consider two nulls as equal?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Can't ri_KeysEqual() consider two nulls as equal?
Date: 2007-04-17 21:16:27
Message-ID: 13541.1176844587@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
A recent discussion led me to the idea that FK triggers are fired
unnecessarily during an UPDATE if the foreign-key column(s) contain
any NULLs, because ri_KeysEqual() treats two nulls as unequal,
and therefore we conclude the row has changed when it has not.
I claim that both ri_KeysEqual() and ri_OneKeyEqual() could consider
two nulls to be equal.  Furthermore it seems like ri_AllKeysUnequal()
should do so too; the case can't arise at the moment because the sole
caller already knows that one of the key sets contains no nulls, but
if this weren't so, the optimization would be actively wrong if we
concluded that two nulls were unequal.

Comments?

Also, I am wondering to what extent the ri_KeysEqual() calls in
ri_triggers.c are redundant, given that commands/trigger.c now has
the smarts to not even queue the trigger when those cases apply.

			regards, tom lane

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-04-17 21:22:51
Subject: pgsql: Also done for PL/pgSQL: < o Add support for WITH HOLD and
Previous:From: Heikki LinnakangasDate: 2007-04-17 21:12:38
Subject: Re: Unhelpful debug tools on OS X :-(

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group