Re: Plan for straightening out the include-file mess

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alex Pilosov <alex(at)acecape(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-interfaces(at)postgresql(dot)org
Subject: Re: Plan for straightening out the include-file mess
Date: 2001-02-08 23:29:02
Message-ID: 13522.981674942@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-interfaces

Alex Pilosov <alex(at)acecape(dot)com> writes:
> when I include files needed for SPI, it drags also a lot of other
> garbage in, which conflicts with other things (namely, trying to get a
> file to simultaneously include SPI and perl headers is impossible).
> I realise it might be a lot of pain to clean up, but, you may consider
> having a separate top-level include for SPI, which would not define (by
> default) things like DEBUG, USE_LOCALE, union semun, etc.

Unless you want to write SPI code that never calls elog(), it's gonna be
tough to avoid the conflict on DEBUG. I suppose sooner or later we'll
have to rename the elog severity symbols ... but it's not a change that
I'm looking forward to making.

In any case there's too much time pressure to consider wide-ranging code
changes for 7.1. Right now I don't want to do more than rearrange the
contents of a small number of include files.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Pilosov 2001-02-08 23:40:21 Re: Plan for straightening out the include-file mess
Previous Message Alex Pilosov 2001-02-08 23:15:16 Re: Plan for straightening out the include-file mess

Browse pgsql-interfaces by date

  From Date Subject
Next Message Alex Pilosov 2001-02-08 23:40:21 Re: Plan for straightening out the include-file mess
Previous Message Alex Pilosov 2001-02-08 23:15:16 Re: Plan for straightening out the include-file mess