| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SP-GiST for ranges based on 2d-mapping and quad-tree |
| Date: | 2012-10-21 07:22:54 |
| Message-ID: | 1350804174.27983.23.camel@jdavis |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2012-09-04 at 17:45 +0400, Alexander Korotkov wrote:
> On Mon, Aug 20, 2012 at 12:25 AM, Jeff Davis <pgsql(at)j-davis(dot)com>
> wrote:
> I am taking a look at this patch now. A few quick comments:
>
> * It looks like bounds_adjacent modifies it's by-reference
> arguments,
> which is a little worrying to me. The lower/upper labels are
> flipped
> back, but the inclusivities are not. Maybe just pass by value
> instead?
>
> * Bounds_adjacent is sensitive to the argument order. Can't it
> just take
> bound1 and bound2?
>
>
> Fixed. Patch is attached.
>
It looks like this is basically the same diff as v0.1. Did something get
mixed up?
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2012-10-21 07:52:57 | Re: Deprecations in authentication |
| Previous Message | Jeff Davis | 2012-10-21 07:03:36 | Re: gistchoose vs. bloat |