Skip site navigation (1) Skip section navigation (2)

Re: WIP checksums patch

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIP checksums patch
Date: 2012-10-01 17:13:49
Message-ID: 1349111629.15580.55.camel@jdavis (view raw or flat)
Thread:
Lists: pgsql-hackers
On Fri, 2012-09-14 at 17:58 -0700, Jeff Davis wrote:
> This is just a rebased version of the patch by Simon here:
> 
> http://archives.postgresql.org/message-id/CA
> +U5nMKw_GBs6qQ_Y8-RjGL1V7MVW2HWBHartB8LoJhnPfxL8g(at)mail(dot)gmail(dot)com

Another thing I noticed about the design of this patch:

It looks like the checksum will usually be wrong in a backup block in
WAL, because it writes the backup block before calculating the checksum
(which isn't done until the time the block is written out).

I think that's OK, because it's still protected by the WAL CRC, and
there's no expectation that the checksum is correct in shared buffers,
and the correct checksum should be set on the next checkpoint. Just an
observation.

Regards,
	Jeff Davis



In response to

pgsql-hackers by date

Next:From: Simon RiggsDate: 2012-10-01 17:14:18
Subject: Re: WIP checksums patch
Previous:From: Stephen FrostDate: 2012-10-01 17:05:57
Subject: Re: Hash id in pg_stat_statements

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group