From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
Subject: | Re: [WIP] plpgsql is not translate-aware |
Date: | 2008-10-08 23:21:23 |
Message-ID: | 1349.1223508083@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tom Lane wrote:
>> --- this looks like it could result in passing a NULL to dgettext,
>> somewhere along the line. Probably safer to pass "postgres".
> Hmm, I was trusting that dgettext is documented to accept a NULL as
> meaning "use the domain previously set with textdomain", but then it is
> possible that elog() will be called before textdomain is set, so you
> might be right. Fixed in this new version.
Another way, which would save some amount of string constant space,
is to have both elog_finish and the ereport macro pass NULL, and let
errstart insert the default:
> + edata->domain = domain ? domain : "postgres";
Otherwise we'll have at least one copy of "postgres" per backend .o
file ...
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Kris Jurka | 2008-10-08 23:36:54 | Fixes for psql describeOneTableDetails |
Previous Message | Josh Berkus | 2008-10-08 23:11:45 | WITH RECURSIVE ... simplified syntax? |