Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Clean up the #include mess a little.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Clean up the #include mess a little.
Date: 2012-08-16 15:15:24
Message-ID: 1345130099-sup-9288@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Excerpts from Bruce Momjian's message of mié ago 15 18:30:40 -0400 2012:
> 
> On Wed, Sep  7, 2011 at 01:20:17AM +0300, Ants Aasma wrote:
> > On Tue, Sep 6, 2011 at 10:18 PM, Alvaro Herrera
> > <alvherre(at)commandprompt(dot)com> wrote:
> > > I wonder what happens if files in the same subdir are grouped in a
> > > subgraph.  Is that possible?
> > 
> > Possible, and done. Also added possivility to add .c files to the graph,
> > coloring by subdir and possibility exclude nodes from the graph. I didn't yet
> > bother to clean up the code - to avoid eye damage, don't look at the source.
> > 
> > Bad news is that it doesn't significantly help readability for the all nodes
> > case. See all_with_subgraphs.svgz.  It does help for other cases.
> > For example parsenodes.h.svgz has the result for
> > render_includes.py --select='nodes/parsenodes.h+*-*' --subgraphs
> > and execnodes.h.svgz for
> > --subgraphs --select='nodes/execnodes.h+*-*'
> 
> Should we add this script and instructions to src/tools/pginclude?

Probably not, but maybe the developer FAQ in the wiki?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2012-08-16 15:19:39
Subject: Re: pgsql: In docs, change a few cases of "not important" to "unimportant".
Previous:From: Tom LaneDate: 2012-08-16 14:59:12
Subject: Re: UNION ALL with WHERE clause does not use Merge Append

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2012-08-16 15:19:39
Subject: Re: pgsql: In docs, change a few cases of "not important" to "unimportant".
Previous:From: Bruce MomjianDate: 2012-08-16 14:49:03
Subject: Re: pgsql: In docs, change a few cases of "not important" to "unimportant".

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group