Skip site navigation (1) Skip section navigation (2)

filenames in pg_basebackup

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgtranslation-translators <pgtranslation-tanslators(at)pgfoundry(dot)org>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: filenames in pg_basebackup
Date: 2012-07-25 19:37:09
Message-ID: 1343244429-sup-2254@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackers
Hi,

I notice that pg_basebackup has lots of messages where file names are
not in quotes.  Is this okay?

There's also this one which is probably against our conventions:
#: pg_receivexlog.c:181
#, c-format
msgid "%s: segment file '%s' is incorrect size %d, skipping\n"

I also wonder about "is" vs. "has" in the above message.

There's also a --help line that's too long.

Apparently, this needs a thorough revision ...

-- 
Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2012-07-25 20:09:42
Subject: Re: [BUGS] BUG #6733: All Tables Empty After pg_upgrade (PG 9.2.0 beta 2)
Previous:From: Bruce MomjianDate: 2012-07-25 17:01:13
Subject: Re: [BUGS] BUG #6733: All Tables Empty After pg_upgrade (PG 9.2.0 beta 2)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group