Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Make pg_basebackup configure and start standby

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
Subject: Re: [PATCH] Make pg_basebackup configure and start standby
Date: 2012-07-03 19:47:29
Message-ID: 1341344849.21530.25.camel@vanquo.pezone.net (view raw or flat)
Thread:
Lists: pgsql-hackers
On mån, 2012-07-02 at 01:10 +0900, Fujii Masao wrote:
> > But I think that part is lacking in functionality: AFAICT it's
> > hardcoded to only handle host, port, user and password. What about
> > other connection parameters, likely passed to pg_basebackup through
> > the environment in that case? isn't that quite likely to break the
> > server later?
> 
> What about something like PQconninfo which returns the connection
> string value established at connection?
> 
> > Maybe the proper way around that is to provide the ability for
> > pg_basebackup to take a full connection string, just like we allow
> > psql to do?
> 
> +1
> 
I think both of these would be necessary to make this work smoothly.

You also need to take into account situations like when pg_basebackup
found a server with the help of PG* environment variables that might no
longer be set when the server tries to start recovery.  So you need
something like PQconninfo.


In response to

Responses

pgsql-hackers by date

Next:From: Matthew WoodcraftDate: 2012-07-03 19:48:55
Subject: Re: enhanced error fields
Previous:From: Magnus HaganderDate: 2012-07-03 19:24:00
Subject: Solaris docs

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group