Skip site navigation (1) Skip section navigation (2)

pg_upgrade log files

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_upgrade log files
Date: 2012-06-29 04:25:58
Message-ID: 1340943425-sup-4814@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackers
Right now, the pg_upgrade output files contain the output of the
commands it runs.  However, it does not contain the actual commands
being run ... so if you want to figure out what is happening, you have
to trace the pg_upgrade source while reading the log file.

This is, to say the least, suboptimal.

I propose this patch which echoes the commands to the respective log
files.  I would backpatch this to 9.2.

As a note, I find the exec_prog() function rather bizarre.  It would be
better if the caller did not have to manually specify a redirection, for
instance.

-- 
Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>

Attachment: 0001-Make-the-pg_upgrade-log-files-contain-actual-command.patch
Description: application/octet-stream (2.0 KB)

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2012-06-29 05:04:13
Subject: Re: pg_upgrade log files
Previous:From: Tom LaneDate: 2012-06-29 02:26:42
Subject: Re: We probably need autovacuum_max_wraparound_workers

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group