Greg Smith <greg(at)2ndquadrant(dot)com> writes:
> The main tricky part was figuring how to convert the \setshell 
> implementation.  That uses strtol to parse the number that should have 
> been returned by the shell call.  It turns out there are a stack of ways 
> to do something similar but return 64 bits instead:

Please choose a way that doesn't introduce new portability assumptions.
The backend gets along fine without strtoll, and I don't see why pgbench
should have to require it.

(BTW, I don't actually believe that the proposed code works at all,
since in general strtoll or other variants aren't going to be macros,
but plain functions.)

			regards, tom lane

In response to

• 64-bit pgbench V2 at 2010-07-05 23:48:22 from Greg Smith

Responses

• Re: 64-bit pgbench V2 at 2010-07-06 00:32:17 from Robert Haas
• Re: 64-bit pgbench V2 at 2010-07-12 19:56:51 from Greg Smith

pgsql-hackers by date

Next:	From: Robert Haas	Date: 2010-07-06 00:32:17
	Subject: Re: 64-bit pgbench V2
Previous:	From: Greg Smith	Date: 2010-07-05 23:48:22
	Subject: 64-bit pgbench V2