Skip site navigation (1) Skip section navigation (2)

Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: oleg(at)sai(dot)msu(dot)su, Denis de Bernardy <ddebernardy(at)yahoo(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Date: 2011-07-06 17:25:53
Message-ID: 13404.1309973153@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-testers
Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> On Tue, 2011-07-05 at 13:56 -0400, Tom Lane wrote:
>> Yeah, I had been thinking along the same lines.  It will require
>> duplicating the search loop, which is a bit annoying, but perhaps that
>> could be factored out as a subroutine.

> Patch attached. The logic in predtest.c was a little more complex, and I
> don't think we have a lot of test coverage in this area (and I didn't
> see an easy way to add many tests), so this will need some review.

Actually, I'd just been working on this myself.  I think the cleanest
solution will be to get rid of the duplicative logic by making
predtest.c use get_op_btree_interpretation().  That will require
changing get_op_btree_interpretation() so it can return amoplefttype
and amoprighttype too, but given the small number of callers, an API
change for it doesn't seem like a problem.

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Jeff DavisDate: 2011-07-06 18:06:11
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Previous:From: Jeff FrostDate: 2011-07-06 17:14:41
Subject: Re: BUG #6092: specific casting required for gist indexing of bigint

pgsql-testers by date

Next:From: Jeff DavisDate: 2011-07-06 18:06:11
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Previous:From: Jeff DavisDate: 2011-07-06 17:00:11
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group