Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] New pg_ctl has retrogressed in error messages

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] New pg_ctl has retrogressed in error messages
Date: 2004-06-01 00:46:17
Message-ID: 13381.1086050777@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I also changed all the pid variables to use pid_t.

Good, but ...

> ! 	fscanf(pidf, "%u", &pid);

this code will fail rather horribly if sizeof(pid_t) != sizeof(int).
Even more to the point, I believe a standalone backend will put
the negative of its PID into the file, and the revised code will fail
to parse that at all.

I think the safest code would be like

	long	tmp;

	fscanf(pidf, "%ld", &tmp);
	if (tmp < 0)
	{
		tmp = -tmp;
		// do anything else needed for backend case
	}
	pid = (pid_t) tmp;


			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Claudio NatoliDate: 2004-06-01 00:55:19
Subject: Re: Can't detect time zone
Previous:From: Tom LaneDate: 2004-06-01 00:33:55
Subject: Re: CVS tip problems

pgsql-patches by date

Next:From: Andrew DunstanDate: 2004-06-01 01:07:07
Subject: Re: [HACKERS] New pg_ctl has retrogressed in error messages
Previous:From: Tom LaneDate: 2004-06-01 00:33:55
Subject: Re: CVS tip problems

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group