Skip site navigation (1) Skip section navigation (2)

Re: Limit the size of explainPopup

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Clemens Eisserer <linuxhippy(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Limit the size of explainPopup
Date: 2012-05-07 20:22:46
Message-ID: 1336422166.2320.56.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Sat, 2012-05-05 at 13:09 +0200, Clemens Eisserer wrote:
> Hi,
> 
> I often use pgadmin's graphical explain to see how queries generated
> be hibernate are planned&executed by postgresql, and it works really
> well.
> However, for very long queries pgadmin3 tries to create windows >
> 65536 pixels, which is not supported by X11 and therefor leads to
> XErrors, which in turn cause pgadmin3 to close because of assetions.
> 
> I would propose to limit the size of the ExplainPopup to the screen
> dimensions, please see the attached patch.
> 

Seems good to me. So I commited it. I had to change it a lot to apply it
to master, but it's commited too there.

Thanks for your patch.


-- 
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com


In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2012-05-07 20:26:14
Subject: pgAdmin III commit: Don't reset breakpoints when folding code
Previous:From: Guillaume LelargeDate: 2012-05-07 20:22:02
Subject: pgAdmin III commit: Fix crashes by limiting the size of explainPopup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group