From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com> |
Subject: | Re: Weird code in pgDomain.cpp |
Date: | 2012-04-21 13:39:39 |
Message-ID: | 1335015579.2322.10.camel@localhost.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Wed, 2012-04-11 at 08:11 +0000, Dave Page wrote:
> On Tue, Apr 10, 2012 at 9:17 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> > On Mon, 2012-04-09 at 19:58 +0530, Ashesh Vashi wrote:
> >> On Sun, Apr 8, 2012 at 3:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>
> >> > On Sun, Apr 8, 2012 at 4:44 AM, Guillaume Lelarge
> >> > <guillaume(at)lelarge(dot)info> wrote:
> >> > > Hi,
> >> > >
> >> > > I was trying to fix a bug on dlgDomain, and I found this code (in
> >> > > pgadmin/schema/pgDomain.cpp):
> >> > >
> >> > > wxString conname = set->GetVal(wxT("conname"));
> >> > > if (!conname.StartsWith(wxT("$")))
> >> > > check += wxT("CONSTRAINT ") + qtIdent(conname) + wxT(" ");
> >> > >
> >> > > I'm wondering why we look for a dollar sign in the first character of a
> >> > > check constraint in a domain. It means nothing to me. Could it be some
> >> > > GreenPlum or EnterpriseDB specific code? or is it something else?
> >> >
> >> > Not that I recall - Ashesh, Sachin - do you know if it's a PPAS thing?
> >> >
> >> Not that I recall.
> >>
> >> It's been there from very long time..
> >> i.e. git log 6003c502d89900b2b2e1538d340db028b1880aa1 -p -n 1
> >> schema/pgDomain.cpp
> >>
> >
> > OK. I got rid of it, but I'm still working on enhancing the domains
> > code. I now have a Constraints node under each domain object, and a new
> > tab in dlgDomain to add as many constraints as you want (only check
> > constraints of course). See screenshots attached.
> >
> > I still need to test it more thoroughly.
>
> Nice!
>
Thanks. I continued the work on this patch. It's almost ready to be
commited. Unfortunately, I still have one issue. The contextual menu of
the Constraints node doesn't allow the user to add a new constraint
(check constraint for a domain, all kind of constraints for a table). I
can still add a constraint when I select the domain (or table), and
right click to get the contextual menu. See patch attached. Any ideas
why it behaves this way?
Once this is fixed, I may have the solution to fix the same issue on the
User Mappings node...
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com
Attachment | Content-Type | Size |
---|---|---|
0001-Lots-of-work-on-domains-and-check-constraints.patch | text/x-patch | 0 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | pgAdmin Trac | 2012-04-21 15:16:39 | Re: [pgAdmin III] #359: Support for renaming domain constraints |
Previous Message | Guillaume Lelarge | 2012-04-20 15:08:19 | Re: Direct debug dialog hangs in OnSize() |