Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen
Date: 2012-04-18 14:03:44
Message-ID: 1334757824.29544.8.camel@vanquo.pezone.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On ons, 2012-04-18 at 09:53 -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > My vote is to revert this altogether and leave it be.  In the
> > alternative, make it an error.
> 
> You mean in HEAD too?  I don't agree with that, for sure.  What this
> patch is accomplishing is to make sure that the less-commonly-used
> programs have similar command-line-parsing behavior to psql and pg_dump,
> where we long ago realized that failure to check this carefully could
> result in very confusing behavior.  (Especially on machines where
> getopt is willing to rearrange the command line.)

OK, if you care strongly about that, make it an error.  But don't just
ignore things.

> I agree with Andrew that this is a bug fix.  I can see the argument
> for not applying it to back branches, but not for declaring that it's
> not a bug.

We shouldn't be backpatching things that are merely confusing.  It works
as designed at the time, after all.  Improvements belong in master.


In response to

Responses

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2012-04-18 14:08:06
Subject: Re: Bug tracker tool we need
Previous:From: Peter EisentrautDate: 2012-04-18 13:56:49
Subject: Re: psql: tab completions for 'WITH'

pgsql-committers by date

Next:From: Robert HaasDate: 2012-04-18 14:11:59
Subject: Re: [COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'write'.
Previous:From: Peter EisentrautDate: 2012-04-18 13:56:43
Subject: pgsql: psql: Add tab completion for CREATE/ALTER ROLE name WITH

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group