Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen
Date: 2012-04-18 09:46:45
Message-ID: 1334742405.29544.5.camel@vanquo.pezone.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On tis, 2012-04-17 at 19:19 -0400, Andrew Dunstan wrote:
> It was discussed. I think the previous behaviour is a bug. It can't be
> sane to be allowed to do:
> 
>     initdb -D foo bar

It's debatable whether it should be allowed.  I don't see anything wrong
with it.  After all, later arguments usually override earlier arguments,
and non-option arguments notionally come after option arguments.  Also,
if this should be disallowed, would you also disallow initdb -D foo -D
bar?

But what I think is worse is that the "bar" is silently ignored now.  If
you think that this is an error, it should produce an error.

My vote is to revert this altogether and leave it be.  In the
alternative, make it an error.



In response to

Responses

pgsql-hackers by date

Next:From: Amit KapilaDate: 2012-04-18 10:32:59
Subject: Re: Improving our clauseless-join heuristics
Previous:From: Tom LaneDate: 2012-04-18 06:28:56
Subject: Re: Improving our clauseless-join heuristics

pgsql-committers by date

Next:From: Tom LaneDate: 2012-04-18 13:53:50
Subject: Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen
Previous:From: Robert HaasDate: 2012-04-18 03:22:56
Subject: Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group