Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Fix for crash while deleting rows on 64 bit systems

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Steven Elliott <selliott4(at)austin(dot)rr(dot)com>
Cc: pgAdmin Hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix for crash while deleting rows on 64 bit systems
Date: 2012-03-18 22:31:34
Message-ID: 1332109894.5148.1.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Sun, 2012-03-18 at 11:37 -0500, Steven Elliott wrote:
> I believe I've fixed a problem where pgAdmin intermittently crashes on
> 64 bit systems while deleting rows.  The issues seems to be that, among
> other things, sqlTable::DeleteRows() in frm/frmEditGrid.cpp attempts to
> remove an element in lineIndex by shifting down the remaining elements.
> Unfortunately the "sizeof" is taking the size of the wrong thing.
> 
> I suspect this is only an issue on systems where pointers and "int"s are
> different sizes, which should be 64 bit systems, but I have only have a
> 64 bit Linux system handy to try.
> 
> Increasing the number of rows that follow the row deleted should
> increase the probability of getting a crash, but Valgrind always
> complains about bad reads and writes for the memmove() in question.
> 
> Steps to reproduce the problem:
> 1) Choose a table that has roughly 200 or more rows.  Here's a dump of
> such a table:
>   http://selliott.org/pgadmin/table-200-rows.sql
> 2) Navigate to the "Edit Data" window (the window navigated to by
> selecting the View Data / View All Rows for the table in question).
> 3) Select a low numbered row, such as the fifth row.
> 4) Right click and select "Delete".  The crash may happen when the
> delete is confirmed after the subsequent dialog.
> 

Quite impressive. I found this bug a few days ago and was unable to fix
it. So thank you very much. I applied it.


-- 
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com


In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2012-03-19 13:59:34
Subject: Re: Fixed issue "Error Message is displayed when the Package is Clicked"
Previous:From: Guillaume LelargeDate: 2012-03-18 22:28:09
Subject: pgAdmin III commit: Fix deleting lines in frmEditGrid with 64bitsystem

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group