Re: Re: [COMMITTERS] pgsql: Update: < * Allow adding enumerated values to an existing

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Dunstan <pgsql(at)tomd(dot)cc>, Brendan Jurd <direvus(at)gmail(dot)com>, Bruce Momjian <momjian(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Update: < * Allow adding enumerated values to an existing
Date: 2008-04-26 17:33:01
Message-ID: 13301.1209231181@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Alvaro Herrera wrote:
>> Another alternative would be internally creating a different temporary
>> enum, rewriting the tables one by one each on its own transaction, and
>> finish by dropping the original enum and renaming the temporary one.
>> This solves the deadlock problem.

> What happens when someone tries to join two of the tables, one that has
> been converted and one that hasn't? You might not have deadlock, but you
> won't have type integrity either, ISTM.

Not to mention the mess you'll be left with if the process fails after
converting some of the tables.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Treat 2008-04-26 18:20:15 Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
Previous Message Tom Lane 2008-04-26 17:26:44 Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-04-26 17:34:39 Re: we don't have a bugzilla
Previous Message Tom Lane 2008-04-26 17:27:50 Re: Proposed patch - psql wraps at window width