Re: psql tab completion for SELECT

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, hubert depesz lubaczewski <depesz(at)depesz(dot)com>
Subject: Re: psql tab completion for SELECT
Date: 2012-02-13 21:25:59
Message-ID: 1329168359.5373.10.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On fre, 2012-02-10 at 01:24 -0500, Tom Lane wrote:
> That seems pretty nearly entirely bogus. What is the argument for
> supposing that the word right after SELECT is a function name? I would
> think it would be a column name (from who-knows-what table) much more
> often.

That's what the patch does. It looks like you misread what I wrote.

> Also, if it is useful, people will expect it to work in more
> places than just the first word after SELECT --- for instance, somebody
> who didn't realize what a kluge it was would expect it to also work
> right after a top-level comma after SELECT. Or probably after a left
> parenthesis in the SELECT list. Etc.

All of psql tab completion works like that. We only complete the first
table after FROM, the first column after ORDER BY, the first privilege
to grant, the first role to grant to, the first table to drop, the first
reloption, etc.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2012-02-13 22:16:58 Re: foreign key locks, 2nd attempt
Previous Message Peter Eisentraut 2012-02-13 21:21:48 Re: psql tab completion for SELECT