Re: add_missing_from breaks existing views

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: add_missing_from breaks existing views
Date: 2005-10-26 03:38:56
Message-ID: 1328.1130297936@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Neil Conway <neilc(at)samurai(dot)com> writes:
> On Tue, 2005-25-10 at 17:43 -0400, Tom Lane wrote:
>> What I suggest we do about this is change addImplicitRTE() to set
>> inFromCl true for implicitly added RTEs, so that the view rule will
>> later be dumped as if the query had been written per spec.

> Sounds reasonable. I wonder if this should be backpatched -- ISTM the
> proper representation of the view is with an explicit FROM list anyway,

I think it'd be reasonable to back-patch it into the branches that have
the add_missing_from variable (how far back did we add that?). But that
won't fix the problem with incompatible dump files from existing
installations.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-10-26 03:41:54 Re: BUG #1993: Adding/subtracting negative time intervals
Previous Message Tom Lane 2005-10-26 03:23:10 Re: The use of (mb)print.c from psql in the scripts directory