Re: Review of patch renaming constraints

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Joshua Berkus <josh(at)agliodbs(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Review of patch renaming constraints
Date: 2012-01-19 19:04:46
Message-ID: 1326999886.19500.3.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On tor, 2012-01-12 at 22:43 -0600, Joshua Berkus wrote:
> Compiling on Ubuntu 10.04 LTS AMD64 on a GoGrid virtual machine from 2012-01-12 git checkout.
>
> Patch applied fine.
>
> Docs are present, build, look good and are clear.
>
> Changes to gram.y required Bison 2.5 to compile. Are we requiring Bison 2.5 now? There's no configure check for it, so it took me quite a while to figure out what was wrong.

I can't reproduce that. I think there might be something wrong with
your installation. The same issue was reported for my COLLATION FOR
patch from the same environment.

> Make check passed. Patch has tests for rename constraint.
>
> Most normal uses of alter table ... rename constraint ... worked normally. However, the patch does not deal correctly with constraints which are not inherited, such as primary key constraints:

That appears to be because creating a primary key constraint does not
set pg_constraint.conisonly correctly. This was introduced recently
with noninherited check constraints.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-01-19 19:05:36 Re: Vacuum rate limit in KBps
Previous Message Alvaro Herrera 2012-01-19 19:04:07 Re: automating CF submissions (was xlog location arithmetic)