Re: Command Triggers

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Greg Smith <greg(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: Command Triggers
Date: 2012-01-18 19:17:36
Message-ID: 1326914211-sup-6553@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Excerpts from Dimitri Fontaine's message of mié ene 18 16:03:29 -0300 2012:

> At the moment the trigger functions are called from
> standard_ProcessUtility() and are given the parse tree as handed over to
> that function, before the parse analysis.
>
> We can easily enough copy the parse tree and do another round of parse
> analysis on it only when some command triggers are going to get called.
> Is the cost of doing so acceptable?

Huh, isn't it simpler to just pass the triggers the parse tree *after*
parse analysis? I don't understand what you're doing here.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-01-18 19:21:03 Re: lots of unused variable warnings in assert-free builds
Previous Message Peter Eisentraut 2012-01-18 19:16:56 Re: lots of unused variable warnings in assert-free builds