Skip site navigation (1) Skip section navigation (2)

Re: Compilation on Debian SID

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Olly Betts <olly(at)survex(dot)com>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Compilation on Debian SID
Date: 2011-12-04 12:45:29
Message-ID: 1323002729.2311.27.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Sun, 2011-12-04 at 10:37 +0100, Guillaume Lelarge wrote:
> On Mon, 2011-11-28 at 17:40 +0000, Dave Page wrote:
> > On Sat, Nov 26, 2011 at 11:05 PM, Olly Betts <olly(at)survex(dot)com> wrote:
> > > On Sat, Nov 26, 2011 at 08:18:31PM +0000, Dave Page wrote:
> > >>
> > > This isn't original wx code - a number of projects define equivalent
> > > macros (and often with the same names, which is where the problems lie
> > > when they do it in API headers and you want to use two or more such
> > > projects at once).
> > >
> > > So just find one with a licence that's compatible:
> > 
> > The irony is that on closer examination we don't actually need the
> > macro at all, as in a Unicode build of wxWidgets (pgAdmin requires
> > Unicode support), it gets defined away to nothing. So, the patch ends
> > up looking like the attached.
> > 
> > Guillaume, please give it a quick check in case I missed anything.
> > 
> 
> Trying it now...
> 

Compiles fine on Fedora 16, Debian Sid, Ubuntu 11.04, Windows XP, and
Mac OS X. So I commited the fix.

Thanks to all who participate in this thread.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2011-12-04 13:02:45
Subject: Re: Compilation on Debian SID
Previous:From: Guillaume LelargeDate: 2011-12-04 12:44:10
Subject: pgAdmin III commit: Fix compilation on Debian

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group