I just noticed that btvacuumpage has two BlockNumber parameters -- blkno
and orig_blkno. The only caller passes them as the same value; the
header comments state that blkno would be different when recursing, but
actually the function implements recursion internally by way of a cute
"goto" trick. So it seems to me that the orig_blkno parameter is
useless -- we could just remove it.
Unless I'm completely missing something?
Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
pgsql-hackers by date
|Next:||From: Simon Riggs||Date: 2011-11-21 22:11:21|
|Subject: Re: btvacuumpage useless "orig_blkno"|
|Previous:||From: Josh Berkus||Date: 2011-11-21 20:49:01|
|Subject: Writeable FDWs?|