Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Improve autocompletion for SELECT statements

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Wander Winkelhorst <w(dot)winkelhorst(at)gmail(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Improve autocompletion for SELECT statements
Date: 2011-11-14 22:31:43
Message-ID: 1321309903.2122.78.camel@localhost.localdomain (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Mon, 2011-11-14 at 21:15 +0100, Wander Winkelhorst wrote:
> On Mon, Nov 14, 2011 at 10:16 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >
> >
> > FYI, I just took a look at the patch and it does touch
> > tab-complete.inc - it certainly should *not* do that, as
> > tab-complete.inc is generated with tabcomplete.pl from the upstream
> > tab-complete.c. Any changes made to it are likely to be lost the next
> > time it's updated. If that file must be changed, then it should be
> > done by tab-complete.pl, though frankly it would be better to push the
> > changes into psql first.
> >
> 
> Could you please tell me how I'm supposed to use tabcomplete.pl, and where
> I can get the correct version of  tab-complete.c?
> 

I suppose it comes from the psql source files, but I don't know more.

You'll need to wait Dave for a more complete answer.

BTW, it means the previous patch needs to follow the same path.

> On Sun, Nov 13, 2011 at 11:06 PM, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
>  wrote:
> > They all are part of fbb_categories. Unfortunately, that doesn't explain
> > the comma
> 
> That's because the comma gets recognized as a table alias :)
> I'm going to take a look at these issues soon.
> 

Yeah, I guessed that was the issue :)


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


In response to

pgadmin-hackers by date

Next:From: Ashesh VashiDate: 2011-11-15 05:03:41
Subject: Re: pgAdmin III commit: Update french translation
Previous:From: Guillaume LelargeDate: 2011-11-14 22:23:44
Subject: Re: Compilation on Debian SID

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group