| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Define INADDR_NONE on Solaris when it's missing. |
| Date: | 2010-01-28 20:16:24 |
| Message-ID: | 13193.1264709784@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Thu, Jan 28, 2010 at 17:16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> However, now that I know the real issue is you're using inet_addr, I
>> would like to know why you're not using inet_aton instead; or even
>> better, something that also copes with IPv6.
> "Path of least resistance?"
> Which method would you suggest?
I haven't actually read the RADIUS patch, but generally we rely on
pg_getaddrinfo_all to interpret strings representing IP addresses.
Is there a reason not to use that?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-01-28 20:19:34 | Re: pgsql: Define INADDR_NONE on Solaris when it's missing. |
| Previous Message | Magnus Hagander | 2010-01-28 20:07:59 | Re: pgsql: Define INADDR_NONE on Solaris when it's missing. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-01-28 20:19:34 | Re: pgsql: Define INADDR_NONE on Solaris when it's missing. |
| Previous Message | David E. Wheeler | 2010-01-28 20:09:54 | Re: Add on_trusted_init and on_untrusted_init to plperl [PATCH] |