Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Add missing format attributes

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add missing format attributes
Date: 2011-09-11 12:24:36
Message-ID: 1315743877.1296.11.camel@vanquo.pezone.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On sön, 2011-09-11 at 16:11 +0900, Fujii Masao wrote:
> On Sun, Sep 11, 2011 at 5:17 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> > Add missing format attributes
> >
> > Add __attribute__ decorations for printf format checking to the places that
> > were missing them.  Fix the resulting warnings.  Add
> > -Wmissing-format-attribute to the standard set of warnings for GCC, so these
> > don't happen again.
> >
> > The warning fixes here are relatively harmless.  The one serious problem
> > discovered by this was already committed earlier in
> > cf15fb5cabfbc71e07be23cfbc813daee6c5014f.
> 
> This commit causes the following warning at the compile time.
> 
> error.c: In function 'ecpg_raise_backend':
> error.c:339: warning: field precision should have type 'int', but
> argument 2 has type 'long unsigned int'

Fixed, thanks.


In response to

pgsql-hackers by date

Next:From: Josh KupershmidtDate: 2011-09-11 14:11:49
Subject: Re: patch: Allow \dd to show constraint comments
Previous:From: Martijn van OosterhoutDate: 2011-09-11 10:36:15
Subject: Re: Thinking about inventing MemoryContextSetParent

pgsql-committers by date

Next:From: Tom LaneDate: 2011-09-11 17:18:42
Subject: pgsql: Fix permissions on pg_largeobject_metadata.h in 9.0 branch.
Previous:From: Peter EisentrautDate: 2011-09-11 12:23:15
Subject: pgsql: Fix additional format warning

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group