Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Add missing format argument to ecpg_log() call

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Add missing format argument to ecpg_log() call
Date: 2011-09-08 19:35:42
Message-ID: 1315510543.27760.2.camel@vanquo.pezone.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On tor, 2011-09-08 at 15:32 -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Add missing format argument to ecpg_log() call
> 
> Oh, fun.  So why isn't there an __attribute__((format...)) decoration
> on ecpg_log()?

I have a larger patch for that.  I just wanted to get the one piece of
obvious breakage backpatched.

I'm also proposing to add -Wmissing-format-attribute to the standard
options set.


In response to

pgsql-hackers by date

Next:From: Daniel FarinaDate: 2011-09-08 20:12:25
Subject: Re: memory-related bugs
Previous:From: Tom LaneDate: 2011-09-08 19:32:19
Subject: Re: pgsql: Add missing format argument to ecpg_log() call

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2011-09-08 19:48:15
Subject: pgsql: Tweak string for uniformity
Previous:From: Tom LaneDate: 2011-09-08 19:32:19
Subject: Re: pgsql: Add missing format argument to ecpg_log() call

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group