Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Clean up the #include mess a little.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Greg Stark <stark(at)mit(dot)edu>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Clean up the #include mess a little.
Date: 2011-09-05 15:07:12
Message-ID: 1315234923-sup-7080@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Excerpts from Magnus Hagander's message of lun sep 05 11:02:23 -0300 2011:
> On Mon, Sep 5, 2011 at 15:55, Greg Stark <stark(at)mit(dot)edu> wrote:
> > On Mon, Sep 5, 2011 at 2:52 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >> Well, I assume we are done for another five years.  The includes removed
> >> were minimal, especially considering five years of work.
> >
> > What I wouldn't mind seeing is a graph of all includes and what they
> > include. This might help figure out what layering violations there are
> > like the one that caused this mess. I think I've seen tools to do this
> > already somewhere.
> 
> http://doxygen.postgresql.org will do some of that, but I think not
> globally - but if you click into one header, I think it shows you the
> map from that perspective.

Yeah; and it isn't always complete, because some graphs tend to get too
unwieldy so it has to prune (you can see this because some nodes show up
with red borders).

I am not sure it is really feasible to build a complete graph for all
headers.  We have too many of them and too many dependencies.

Another useful graph to see is what files include a given header.  A
funny thing is that doxygen doesn't always display this; for example
http://doxygen.postgresql.org/rel_8h.html

-- 
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: David FetterDate: 2011-09-05 15:21:46
Subject: Re: regress test failed
Previous:From: Bruce MomjianDate: 2011-09-05 14:30:32
Subject: Help with pg_locks query

pgsql-committers by date

Next:From: Bruce MomjianDate: 2011-09-05 15:51:35
Subject: Use of literal in SGML docs
Previous:From: Magnus HaganderDate: 2011-09-05 14:02:23
Subject: Re: [COMMITTERS] pgsql: Clean up the #include mess a little.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group