| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Jeremy Drake <pgsql(at)jdrake(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Date: | 2011-09-02 16:53:12 |
| Message-ID: | 1314981653-sup-7930@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Excerpts from Bruce Momjian's message of vie sep 02 12:20:50 -0300 2011:
> Wow, that is interesting. So the problem is the inclusion of
> replication/walsender.h in xlog.h. Hard to see how that could cause the
> cube regression tests to fail, but of course, it is.
Hmm, so you included walsender.h into xlog.h? That seems a bit funny
considering that walsender.h already includes xlog.h. It seems the
reason for this is only the AllowCascadeReplication() definition. Maybe
that should go elsewhere instead, for example walsender.h?
I wonder if there should be a new header, something like
walsender_internal.h, for stuff like WalSnd and WalSndCtlData struct
defs.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-09-02 18:29:43 | pgsql: Teach ANALYZE to clear pg_class.relhassubclass when appropriate. |
| Previous Message | Tom Lane | 2011-09-02 16:52:05 | Re: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-09-02 17:00:37 | Re: postgresql.conf archive_command example |
| Previous Message | Tom Lane | 2011-09-02 16:52:05 | Re: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |