Skip site navigation (1) Skip section navigation (2)

Re: cataloguing NOT NULL constraints

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: cataloguing NOT NULL constraints
Date: 2011-08-03 18:17:41
Message-ID: 1312395396-sup-9601@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackers
Excerpts from Alvaro Herrera's message of mié ago 03 13:12:38 -0400 2011:

> ... ah, maybe what we could do is have gram.y create a ColumnDef in the
> new production, and stick that in cmd->def instead of the list of
> constraints.  So parse_utilcmd would have to know that if that node
> IsA(ColumnDef) then it needs to deal with column constraints.  It seems
> a bit cleaner overall, though it's still wart-ish.

Yes, this works, thanks for the suggestion.  Attached.

-- 
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment: alter_add-3.patch
Description: application/octet-stream (14.3 KB)

In response to

pgsql-hackers by date

Next:From: David E. WheelerDate: 2011-08-03 18:20:49
Subject: Re: Further news on Clang - spurious warnings
Previous:From: Peter EisentrautDate: 2011-08-03 18:17:33
Subject: Re: Further news on Clang - spurious warnings

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group