Skip site navigation (1) Skip section navigation (2)

Re: lazy vxid locks, v3

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: lazy vxid locks, v3
Date: 2011-08-01 15:21:19
Message-ID: 1312212079.29391.111.camel@jdavis (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, 2011-08-01 at 08:12 -0400, Robert Haas wrote:
> > Is the "&& LocalTransactionIdIsValid(lxid)" a guard against calling
> > VirtualXactLockTableCleanup twice? Can that happen? Or is it just
> > defensive coding to avoid making an additional assumption?
> 
> lxid there is just a local variable storing the value that we
> extracted from fpLocalTransactionId while holding the lock.  I named
> it that way just as a mnemonic for the type of value that it was, not
> intending to imply that it was copied from MyProc->lxid.

I know, this is the other purpose of fpLocalTransactionId that I was
talking about. Is it just a guard against calling
VirtualXactLockTableCleanup twice?

Regards,
	Jeff Davis


In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2011-08-01 15:25:01
Subject: Re: Hot standby and GiST page splits (was Re: WIP: Fast GiST index build)
Previous:From: Robert HaasDate: 2011-08-01 15:18:36
Subject: Re: Access to current database from C-language function

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group